add custom devDep pattern for import/no-extraneous-dependencies #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import/no-extraneous-dependencies
is an ESLint rule that is intended to ensure that you don't import libraries installed asdevDependencies
from inside non-dev code. It needs to be configured with glob patterns to let it know which files should be considered "dev-only".Several of our projects have had to set up custom overrides of the this rule because the default config (configured in
eslint-config-airbnb-base
) was not aware of these dev-only files. This is an attempt to centralize those exceptions so that each project doesn't have to roll their own. Specifically, I am adding:'.storybook/**'
and'stories/**'
(Storybook files used in Linoleum)**/setupTests.js
(Create React App test setup file, used in web apps)**/*.config.js
(misc. config files used throughout our apps, including Webpack, Rollup, Babel, ESLint, postcss, etc.)Since we are overriding the rule definition from
eslint-config-airbnb-base
, I also needed to copy the test file patterns we use from their rule set.