Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*Improvement* Auto-close live view of disconnected clients #142

Open
DeadmanLabs opened this issue Aug 7, 2019 · 3 comments
Open

*Improvement* Auto-close live view of disconnected clients #142

DeadmanLabs opened this issue Aug 7, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@DeadmanLabs
Copy link

Port scanners leave a closed session in the live view of the player so a feature should be added to remove those sessions as they are not live anymore. If some wish to keep these sessions open after they close, then why not auto-open the replay file?

@Pourliver
Copy link
Contributor

You're right that getting scanned opens a lot of tabs, which can be annoying. Auto-closing would help, but we still need a way to know that a connection happened (from the pyrdp-player) so we can look at the replay files. Definitely something could be done here!

@Pourliver Pourliver added the enhancement New feature or request label Aug 13, 2019
@Res260
Copy link
Collaborator

Res260 commented Aug 13, 2019

I think I implemented something so that port scans dont make a replay file. If they leave a tab open, it can indeed be confusing and frustrating. I'm unsure right now what is the best way to implement that, but it would indeed be a welcome change.

@alxbl
Copy link
Collaborator

alxbl commented Apr 8, 2020

I would auto-close all "trash" connections that do not complete the connection sequence within a set amount of time. For the purpose of the live tabs, this could be considered as the first frame buffer update to avoid requiring too much refactoring. That should reduce the noise by a significant amount.

Auto-closing of tabs with actual user input would have to be an opt-in setting as it can be confusing, especially if you're watching the tab and it closes on you abruptly. Another QoL thing we could do is maybe "move" the disconnected tabs to the replay pane after some time passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

5 participants