Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Client-Only Transparent Proxy #239

Merged
merged 5 commits into from
Jul 23, 2020
Merged

Feature: Client-Only Transparent Proxy #239

merged 5 commits into from
Jul 23, 2020

Conversation

alxbl
Copy link
Collaborator

@alxbl alxbl commented Jul 21, 2020

This pull request adds support for client-only transparent proxying (See docs/transparent-proxy.md for firewall setup) For scenarios where a subnet is to be spoofed (via ARP, for instance) but connections to the target server should be direct.

Caveats: It will fail noisily (impossible to connect) if the target servers have NLA enabled. Nothing we can do about this.

Also this includes some bug fixes:

Missing:

  • Release Notes
  • Maybe Documentation on Client-Only proxying?

Copy link
Member

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

pyrdp/mitm/AttackerMITM.py Show resolved Hide resolved
pyrdp/mitm/AttackerMITM.py Outdated Show resolved Hide resolved
@obilodeau
Copy link
Member

I don't see what change fixes #203.

@alxbl
Copy link
Collaborator Author

alxbl commented Jul 21, 2020

I don't see what change fixes #203.

https://github.com/GoSecure/pyrdp/pull/239/files#diff-1b1cfb078e7a51aa889289ef74c8c7f0R273

@alxbl alxbl merged commit 58dbabe into master Jul 23, 2020
@obilodeau obilodeau deleted the full-transparent branch August 6, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoneError when using a payload in MITM without Player running
2 participants