Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for MITM components and other PyRDP features #267

Open
xshill opened this issue Nov 19, 2020 · 1 comment
Open

Add tests for MITM components and other PyRDP features #267

xshill opened this issue Nov 19, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@xshill
Copy link
Collaborator

xshill commented Nov 19, 2020

So I think we could definitely use some tests in the whole project to help us identify potential bugs. However, at this point, spending time writing tests is quite a daunting task and not necessarily the most fun thing either.

However, as we work on a component to improve or fix it, I think it would be worth spending time implementing tests for that component so that eventually we end up having tests for most components / features.

This is a bit more of an abstract issue to describe the overall goal but more concrete issues like "Add tests for DeviceRedirectionMITM" for example should be opened as the opportunities arise.

@xshill xshill added the enhancement New feature or request label Nov 19, 2020
@xshill
Copy link
Collaborator Author

xshill commented Nov 19, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant