Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for DeviceRedirectionMITM #268

Closed
xshill opened this issue Nov 19, 2020 · 1 comment
Closed

Add tests for DeviceRedirectionMITM #268

xshill opened this issue Nov 19, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request waiting-merge A fix for this exists but hasn't been merged yet
Milestone

Comments

@xshill
Copy link
Collaborator

xshill commented Nov 19, 2020

See #267.

Since the DeviceRedirectionMITM component needs changes anyway, this could be a good time for adding tests. Among the things that should be tested are:

@xshill xshill self-assigned this Nov 19, 2020
@xshill xshill added the enhancement New feature or request label Nov 19, 2020
@xshill xshill changed the title Add tests for RDPDRMITM Add tests for DeviceRedirectionMITM Nov 19, 2020
@xshill
Copy link
Collaborator Author

xshill commented Nov 23, 2020

After experimenting a bit with unittest.mock, it seems much simpler to do than I originally thought.

Here are some things we would like to test:

  • Make sure that client credentials are logged
  • Make sure that responses to forged requests don't get sent to the server
  • Make sure that open files are properly closed when a close request is received
  • Make sure that read responses only handles files that we've opened
  • Make sure that duplicate files are deleted
  • Make sure that the file mapping contains proper info (e.g: sha1 hash, remote path)
  • Make sure that the file mapping gets saved when it's supposed to

@xshill xshill added the waiting-merge A fix for this exists but hasn't been merged yet label Nov 25, 2020
@xshill xshill added this to the v1.1.0 milestone Nov 26, 2020
@xshill xshill mentioned this issue Dec 23, 2020
@xshill xshill closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting-merge A fix for this exists but hasn't been merged yet
Projects
None yet
Development

No branches or pull requests

1 participant