Copy image before drawing cursor. Fixes #271. #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obilodeau
reviewed
Jan 5, 2021
|
No, it was reassigned before being used
…On Tue., Jan. 5, 2021, 1:47 p.m. Olivier Bilodeau, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pyrdp/player/Mp4EventHandler.py
<#273 (comment)>:
> @@ -132,8 +132,7 @@ def onFinishRender(self):
def _writeFrame(self, surface: QImage):
w = self.stream.width
h = self.stream.height
- surface = surface.scaled(w, h) if self.scale else surface
- frame = av.VideoFrame.from_image(ImageQt.fromqimage(surface))
The frame variable was not used?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#273 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENCZWNYKKDX4NJHMRCSINLSYNNCXANCNFSM4VTQGPRQ>
.
|
obilodeau
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering an MP4 file, copy the image before drawing the cursor to avoid getting mouse pointer ghosts (see #271).