File naming #272
Merged
File naming #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
November 17, 2020 17:19
The forged request IDs were never incremented causing requests to be "forgotten" when a response to a simultaneous request was received.
obilodeau
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issues #261, #264, #268, #270.
Most notably:
filesfolder and are named by hash for easy detection of duplicatesfilesystemsfolder contains the filesystem clones, and files in this directory are symbolic links to the files in thefilesfolderPath.symlink_tomethod in Python and the documentation suggests that this should work on both Linux and WindowsDeviceRedirectionMITMandFileMappingmapping.jsonfile (the information it would contain should be easy to find anyway with the command line, and this simplifies the code)