Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Negotiation Request flags were set before checking them. #283

Closed
xshill opened this issue Jan 22, 2021 · 0 comments · Fixed by #285
Closed

Check if Negotiation Request flags were set before checking them. #283

xshill opened this issue Jan 22, 2021 · 0 comments · Fixed by #285
Assignees
Labels
bug Something isn't working

Comments

@xshill
Copy link
Collaborator

xshill commented Jan 22, 2021

When the client sends no flags, we set them to None instead of 0. This is fine, because it allows us to distinguish between no flags field and a flags field set to 0. However, we should check that the field is not None before checking for the presence of a flag.

@xshill xshill added the bug Something isn't working label Jan 22, 2021
@xshill xshill self-assigned this Jan 22, 2021
@xshill xshill linked a pull request Jan 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant