Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with None negotiation flags #285

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Fix bug with None negotiation flags #285

merged 1 commit into from
Jan 26, 2021

Conversation

xshill
Copy link
Collaborator

@xshill xshill commented Jan 22, 2021

See issue #283

obilodeau
obilodeau approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on the test! Feel free to merge. Don't forget the changelog after 😉

@xshill xshill linked an issue Jan 26, 2021 that may be closed by this pull request
Check if Negotiation Request flags were set before checking them. #283
Closed
@xshill xshill merged commit 775e7d0 into master Jan 26, 2021
@xshill xshill mentioned this pull request Jan 26, 2021
Closed
@obilodeau obilodeau deleted the fix-nego-flags branch August 6, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obilodeau obilodeau obilodeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if Negotiation Request flags were set before checking them.
2 participants
@xshill @obilodeau