Watch for disconnection events in DeviceRedirectionMITM #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obilodeau
reviewed
Mar 31, 2021
| def onDisconnection(self, reason): | ||
| if not self.file.closed: | ||
| self.file.close() | ||
| Path(self.file.name).unlink(missing_ok=True) |
There was a problem hiding this comment.
why are we removing files on disconnection? Is it because they would be incomplete?
There was a problem hiding this comment.
Yes, if they were complete the finalize function would have been called and self.file.closed would be True.
There was a problem hiding this comment.
Wouldn't we want to keep partial transfers? Maybe label them as such. Let's say we are monitoring a session where someone uploads a large zip or a VMDK. We could still extract intel from the file even if it's incomplete. Just a thought.
| class FileMappingTest(unittest.TestCase): | ||
| class X224MITMTest(unittest.TestCase): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watch for disconnection events and make sure to close files when either the client or server disconnects.
This should help with #265.