Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clientIp to all JSON log records #321

Closed
obilodeau opened this issue Jul 5, 2021 · 1 comment · Fixed by #326
Closed

Add clientIp to all JSON log records #321

obilodeau opened this issue Jul 5, 2021 · 1 comment · Fixed by #326
Labels
enhancement New feature or request
Milestone
v1.1.0

Comments

@obilodeau
Copy link
Member

It would be useful to filter out messages from known test systems. Correlating with a automatically generated sessionID would require state tracking (assigning clientIp to session then tracking session).

I'm going to try to add clientIp to all JSON logs after it is known.
@obilodeau obilodeau added the enhancement New feature or request label Jul 5, 2021
@obilodeau obilodeau added this to the v1.1.0 milestone Jul 5, 2021
@obilodeau
Copy link
Member Author

This is more complicated than anticipated... Our logging is complex and the client IP address information arrives after many logging adapters were instantiated.

@obilodeau obilodeau mentioned this issue Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Add clientIp to all JSON logs GoSecure/pyrdp
1 participant
@obilodeau