Reduce memory usage of pyrdp-convert.py's conversion to video #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See doc comments for the benefits
obilodeau
changed the title
|
Also see #352. Tests are in-progress. Will post results once done. |
This is required due to QT's implicit data sharing. Further updates to unflushed buffers (ie: cache updates) would corrupt other portion of the images. The bug was not visible until we started to try to plug memory leaks with our rle C extension.
Returns a bytearray and takes an immutable bytes object as input. Reference counting was checked to be valid. See #352 for the whole memory analysis
This was referenced Sep 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first change is to use an MP4 streaming format instead of the default MP4 encoder.
The second makes our BitmapCache track the QImage backing buffer in addition to the QImage itself.
The last one plugs a memory leak in the run length encoding decoding routine in our C extension
rle.c.See #352 for the whole story including profiling and performance testing.