L33t words not matched as expected #28
Assignees
Comments
|
Yup, that for sure looks like an issue and it wasn't caught by the test cases. I'll take a look into that shortly. |
|
Found the issue, working on a fix now. My un-leet code was not as robust as the code in zxcvbn. I'll fix that right up shortly. |
Tostino
added a commit
that referenced
this issue
Apr 7, 2017
…substitution possible, whereas that isn't really true in reality. For simple l33t conversion, characters like: 1, !, and | can be mapped to both i and l. This fixes the reported issue, and adds a test case to cover it.
|
Alright, I fixed this issue in the commit referenced above. Please let me know if you find any additional issues with it. |
|
Nice. I'll see if I can reproduce this Monday. Looking at the commit it looks you fixed it though. |
|
Works for me now. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
L33tified words seem to get only partial dictionary matches.
Result
The password
Ch1ck3n1970currently yields:BruteForceMatch:CBruteForceMatch:hBruteForceMatch:1BruteForceMatch:cDictionaryMatch:ken(male_names)YearMatch:1970For comparison, this is
Chicken1970:DictionaryMatch:chicken(passwords)YearMatch:1970Expected
For
Ch1ck3n1970I would expect the same matches asChicken1970:DictionaryMatch:chicken(passwords, Leet Substitutionstrue)YearMatch:1970The text was updated successfully, but these errors were encountered: