Add option processImport set to true by default.

[abarre]

This pull-request add an option to select if we process the import.

For the integration of clean-css in our project, I need to disable the processing of the import statement.

The bad behavior we saw :

We use clean-css to minify a file that is downloaded from another server. So, clean-css doesn't find the css imported with relative path in the server that run the minifier and it just remove the line.

If you want to add this option to the binary, I can patch the pull-request. I don't think that it's necessary since the files will be likely local in this case.

[GoalSmashers]

Thanks @abarre for the PR! We were thinking about handling non-local resources by fetching them and then optimizing (there's an issue opened for this: #85). Can you think of any other case when someone does not want to process imports?

Not really sure what's the best way to handle that:

• Implement Support protocol @imports #85 and skip processImport option
• Have them both (as long as there's some other use case for the switch).

Thoughts?

[abarre]

Thanks for consider the PR.

In my opinion, you should consider to have them both : add an option and implement a basic version to fetch the non-local resource.

In critical application, somebody could disable it because of performance concerns due to cost of fetching the file on the filesystem or over the network.

If you want to implement an http request, be sure to let the possibility to override the request ( because of proxy, authentification, host header...). For instance, in our service, we override the Host header of the requests sent to origin server.

[abarre]

Actually, after reading again the #85, it seems to be a different issue than the one we have.
In my case, we would need to fetch both the relative and absolute url from the origin server. #85 seems to consider only absolute url.

[GoalSmashers]

Very good points @abarre. I totally agree with you regarding network considerations.

We should also have a command line option to turn import processing off, something like -s / --skip-imports as that's an optional functionality. Would you dare to add them or should we pick it up from you?

[GoalSmashers]

#85 will surely be a complicated one. Thanks for pointing that out.

[GoalSmashers]

Please add whitespace as we do elsewhere.

[abarre]

I don't get the point. Can you explain or do the modification ?

[GoalSmashers]

Sorry, just like this: { processImport: false } to match formatting with other places.

[GoalSmashers]

@abarre looks great! Merging!

[GoalSmashers]

@abarre 1.0.12 is out in npm repository - thanks a million!