Fortify media playback #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a desire to remove the current image without having to specify a specify an explicit blank image.
MIDI sequencers take up system resources and need to be disposed of when no longer in use.
Tested with:
git@github.com:FrozenWolf4887/TeaseAIJava-TestPersonality.git
This separates the media handlers into three respective modules, video,
audio, and image. Additionally it addresses various issues found with
testing, although most of the issues only pertain to error conditions.
Video playback issues addressed:
* Disposes of MediaPlayers when finished or failed
* Fix hanging when playing invalid files
* Fix images remaining locked when playing invalid files
* Fix crash calling stopVideo() when no video is playing
* Stop previously playing video before starting a new one
Audio playback issues addressed:
* Disposes of MediaPlayers when finished or failed
* Fix hanging when playing invalid files
* Fix images being unlocked when audio has finished playing
* Fix stopAllAudio() only stopping the last playing occurrence of a file
* Cleans up list of playing audio
There is an outstanding issue that was also present in TAJ 1.3 where
calling playVideo('http://...') would often hang. The contained
MediaPlayer object fails to issue any callbacks when the video has
finished, and its status remains as PLAYING. Calling stop() on the
MediaPlayer does nothing. This causes a hang in TAJ when waiting for
the video to finish either successfully or in error. This problem may
be limited to Linux and hasn't been evaluated in Windows. It occurs
with both OpenJFX 15.0.1 and OpenJFX 16; other versions have not been
tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses various media playback issues, detailed in the respective commits.
Tested extensively on Linux with:
git@github.com:FrozenWolf4887/TeaseAIJava-TestPersonality.git
Also has been used repeatedly with the Spicy personality for over six weeks.