Skip to content

Commit

Permalink
Clean up comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jazzthief committed Jan 9, 2023
1 parent a645168 commit c689362
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions lib/sqlalchemy/sql/elements.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@
_T = TypeVar("_T", bound="Any")
_OPT = TypeVar("_OPT", bound="Any")
_NT = TypeVar("_NT", bound="_NUMERIC")

_NMT = TypeVar("_NMT", bound="_NUMBER")


Expand Down Expand Up @@ -1537,7 +1538,6 @@ def shares_lineage(self, othercolumn: ColumnElement[Any]) -> bool:

return bool(self.proxy_set.intersection(othercolumn.proxy_set))

# QUESTION: an override returns FrozenSet[ColumnElement[_T]]
def _compare_name_for_result(self, other: ColumnElement[Any]) -> bool:
"""Return True if the given column element compares to this one
when targeting within a result row."""
Expand Down Expand Up @@ -2258,7 +2258,6 @@ def _select_iterable(self) -> _SelectIterable:

_allow_label_resolve = False

# QUESTION: mypy bug
@property
def _is_star(self) -> bool:
return self.text == "*"
Expand Down Expand Up @@ -4403,7 +4402,7 @@ def _compare_name_for_result(self, other: ColumnElement[Any]) -> bool:
def description(self) -> str:
return self.name

# QUESTION: Union[_anonymous_label, _truncated_label]
# caught Union[_anonymous_label, _truncated_label] at runtime
@HasMemoized.memoized_attribute
def _tq_key_label(self) -> Optional[str]:
"""table qualified label based on column key.
Expand Down

0 comments on commit c689362

Please sign in to comment.