Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 6810 type annotate sqlalchemy.sql.elements #5

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Issue 6810 type annotate sqlalchemy.sql.elements #5

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ebf5e73
Apply some runtime types, start fixing errors
jazzthief Dec 28, 2022
5ec44bb
Allow untyped calls; fix some more types
jazzthief Dec 30, 2022
710c178
Fix more types
jazzthief Jan 2, 2023
2ca8fc9
Fix some more types
jazzthief Jan 3, 2023
7e6036f
Fix some more types; focus on method overrides
jazzthief Jan 5, 2023
0de1535
Disallow untyped calls; fix more types
jazzthief Jan 9, 2023
b119b9e
Add return annotation to fix untyped calls from sql.elements
jazzthief Jan 9, 2023
ef6ca74
Clean up
jazzthief Jan 9, 2023
3a135f7
Clean up comments
jazzthief Jan 9, 2023
28f43c9
Refine some types; clean up
jazzthief Jan 10, 2023
ccad2f0
Remove remaining ignores; refine some types
jazzthief Jan 10, 2023
85aeecc
Refine more types
jazzthief Jan 10, 2023
85b8101
More type fixes
jazzthief Jan 13, 2023
bdc1f76
Fix some of remaining errors
jazzthief Jan 20, 2023
1951e75
Replace asserts with conditionals
jazzthief Jan 23, 2023
2bc6140
Remove explicit None check
jazzthief Jan 23, 2023
e705f39
Narrow down a problematic type
jazzthief Jan 25, 2023
cb068fd
Use `Self` instead of a `TypeVar`
jazzthief Mar 14, 2023
34561d3
Address comments
jazzthief Mar 24, 2023
c85b4b9
Update `cache_anon_map` import
jazzthief Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sqlalchemy/sql/base.py
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to check-out GitHub's new file-level comments feature. :D

Anyways, I'll do a review of the changes tomorrow, if you need it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, well, it's a bit late for that - Mike has taken over it already. I had to push a rebase because main has gone pretty far forward, so sorry if you got an alert

Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def proxy_set(self) -> FrozenSet[ColumnElement[Any]]:
raise NotImplementedError()

@classmethod
def _create_singleton(cls):
def _create_singleton(cls) -> None:
obj = object.__new__(cls)
obj.__init__() # type: ignore

Expand Down
Loading