-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issues with theme on macos #1
Comments
I don't have a MacOS to test the theme, so its so difficult to me fix o make compatible with that OS, Sorry. 💙 For now you could delete the |
you could try adding this code to the end of userChrome.css.
try a smaller or bigger pixels number to look it well to you. |
like I said I don´t have that OS to play with the css to make it compatible, I just can give you some code to try solve a little things, to make a space in the top add this too:
And for the window controls I give up jeje, I would need that OS to test. |
I might actually research that myself, might make a pull request some day, i am going to edit the config now! |
that would be perfect. |
I am learning chromeCSS right now, i know how to move the buttons from left to right, but no vertical layout yet. |
for default in macOS that buttons stay in the left, are you changing them to the right? |
you could try this code to make the window controls vertical:
|
That did not work, but i can try to modify this code |
do you use the developer console? In the first post of reddit/r/firefoxcss has the steps to enable. then you can select a element with the selector and see the id and classes to edit with css.
|
i am using the dev console, ill try just that out |
Update: if i try changing the background color, it does nothing, only in the buttonbox container |
if you try to give a max-width and min-width to 40px for example and a bigger height maybe could work ejje, well, it my time to sleep, maybe you could play with some rules to see if apply. |
Buenas noches |
the first tab always was so near to the border of the windows? |
I removed the padding tab rule to test out if it was conflicting in a way |
with the developer console in the right side after selected that element are you tried to uncheck some css rule to see what happens? |
¿? ¿What element? ¿And what rule? |
Yeah, maybe we should call on discord some day |
I tried this code in linux and works, maybe this could work in macOS:
PD: The code that change the icons isn't necessary. |
One moment, i realised i have a bug, easy fix |
Step 1: Remove OGX_MENU.css
|
please you could update the ogx_left-sidebar.css with the one that I updated in the github page, I did a little update to fix the menu button when the ogx_menu.css is deleted, and after that pls give me other SS, sorry for the inconvenient. |
what did it fix? i see no difference |
the hamburger menu dont show a black background by default. in your SS see that background. |
oh yes i see it now |
thanks for your help, sad that the window control buttons didn't make it work jeje. I appreciate your time. |
No problem, im happy to help when you need me! |
one last questions, the top padding we added is for maximized and normal windows right? you deleted that part of the code cause that only applied in maximized window? |
yeah, if i put it in fullscreen, the tabs go to the edge of the window, but it can be fixed on your end, and if i put it in maximized, in most firefox themes the padding goes away, which is also fixed here now. |
I will add the platform: macos in the second rule, you forgot to added jeje
|
I updated ogx_contextual-menu.css , check it to update that file and make me know if that solves the problem. |
ok, ill check it out |
it looks a looooott better now |
identical with opera GX |
glad to know it. :) |
ill report any further issues, im glad to have worked with you! Can i update the readme.md so that i appear as a contributor? |
to do that you can fork my repository and after that edit the file
And after that you make a pull request, I'll accept and after that you'll see you as a contributor. |
or I put your name in the MacOS section, an easy way. |
i made a pr, and maybe adding a name that links to my profile would be nice, it is the first time i contribute to a project |
Thanks a lot! I am honored |
it's done now. ❤ |
and other thing, the close button in the favicon maybe will interfere with the sound icon button, I dont know how opera work with sound tabs. |
I will make another issue for this |
I think to to the nature of the placementof mac os's title bar buttons the theme has trouble functioning on macos firefox. The menu bar button is on the left of the firefox window for some reason, underlaying the buttons. Otherwise the theme looks great!
The text was updated successfully, but these errors were encountered: