Change application/version setting source to remove redundancy #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is your intent to do the equivalent C# changes in a different PR? |
This change remaps some settings It removes `xr/tilt_five/application_id` and uses `application/config/name` instead. It removes `xr/tilt_five/application_version` and uses `application/config/version` instead. This change is in alignment with the intended use of these fields for identifying the application in the T5 service logging. Additionally if `xr/tilt_five/default_display_name` does not have a supplied value `application/config/name` is used. Changed for gdscript and C# also
patrickdown
force-pushed
the
move_app_info
branch
from
0c2590a
to
dfea87e
Compare
Wow, completely missed that. I amended it with C# changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change remaps some settings
It removes
xr/tilt_five/application_idand usesapplication/config/nameinstead.It removes
xr/tilt_five/application_versionand usesapplication/config/versioninstead.This change is in alignment with the intended use of these fields for identifying the application in the T5 service logging.
Additionally if
xr/tilt_five/default_display_namedoes not have a supplied valueapplication/config/nameis used.