Implement glasses display name query #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update the gdscript side to maintain functional parity between the two plugins?
|
|
@Jonathan-Stevens I looked over your pull request and it looks fine for the c# side. It would be nice if the gdscript version was included too. Also the GodotVR repo folks like their PRs to be squashed into a single commit. I know this is a pain, if you like I can pull your branch into my repo and do fixup there and submit it. I'll put you as a co-author in the comments. |
|
I've reworked this a little and submitted as PR#72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, getting the UI Display Name for a pair of Tilt Five glasses always returns the same string
T5ProjectSettings.DefaultDisplayName.This change exposes the native function required to retrieve the display name defined in the Tilt Five Control Panel, then revises the C# plugin to use it.
Additionally, this PR ensures that the application name is passed back to the Control Panel, rather than the glasses display name.