Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced pickable object highlighting #109

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request fixes issue #107 by adding numerous options for highlighting pickable objects. The change includes:

  • Modified Object_pickable to emit a highlight_updated signal when the …highlight changes.
  • Added a highlighter object which reacts to highlight_updated by changing mesh materials.
  • Added a highlighter object which reacts to highlight_updated by showing/hiding itself (and children).
  • Added a highlighter object which reacts to highlight_updated by showing/hiding a billboard target ring.

…highlight changes.

Added a highlighter object which reacts to highlight_updated by changing mesh materials.
Added a highlighter object which reacts to highlight_updated by showing/hiding itself (and children).
Added a highlighter object which reacts to highlight_updated by showing/hiding a billboard target ring.
@BastiaanOlij BastiaanOlij merged commit 663ddb8 into GodotVR:master Mar 19, 2022
@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Mar 19, 2022
@BastiaanOlij BastiaanOlij added this to the 2.4.0 milestone Mar 19, 2022
@BastiaanOlij
Copy link
Member

Very cool!

@Malcolmnixon Malcolmnixon deleted the pickable-highlights branch March 19, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants