Add render target size multiplier option to StartXR #450
Conversation
addons/godot-xr-tools/xr/start_xr.gd
Outdated
| @@ -87,6 +90,9 @@ func _get_configuration_warnings() -> PackedStringArray: | |||
| func _setup_for_openxr() -> bool: | |||
| print("OpenXR: Configuring interface") | |||
|
|
|||
| # Set the render target size multiplier - must be done befor initializing interface | |||
| xr_interface.render_target_size_multiplier = render_target_size_multiplier | |||
There was a problem hiding this comment.
I don't actually think the before initialize is important here, especially seeing OpenXR is initialized before you even run any GDScript code. I think that was a leftover remark from another property.
You can change the size multiplier on the fly and it will reallocate the buffers. It's just not something you want to do regularly.
|
Need to double check if this works with the newly release 4.0.3, if so we should merge this. |
I just checked and it wasn't back-ported into 4.0.3. Looks like we may need to wait for 4.1. |
|
The render target size multiplier was merged into the 4.1 release (see https://godotengine.github.io/godot-interactive-changelog/#4.1) and I just tested this works on 4.1.1 |
|
We still have many people using Godot 4.0.3, so this now detects whether the feature is implemented. |
Malcolmnixon
force-pushed
the
render-target-size-multiplier
branch
from
4390b17
to
8ecf447
Compare
…4.0.3 or later Handle both Godot 4.0 and 4.1 by detecting whether render_target_size_multiplier is implemented. Add comment explaining Godot 4.1+ support. Added change to VERSIONS.md
Malcolmnixon
force-pushed
the
render-target-size-multiplier
branch
from
8ecf447
to
0fe2a33
Compare
This pull request adds the Render Target Size Multiplier option to godot-xr-tools. This requires Godot 4.0.3 or later (godotengine/godot#73558).