Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of environments and physics settings #456

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Cleanup of environments and physics settings #456

merged 1 commit into from
Apr 22, 2023
+64 −28

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request:

  • Removes the "default_env.tscn" environment setting from the scene_base.tscn addon
  • Adds the "default_env.tscn" envrironment to all the demo scenes
  • Updates the physics layer names to match those set by the plugin script
  • Updates the physics penetration settings to the new recommended default

@Malcolmnixon Malcolmnixon marked this pull request as ready for review April 19, 2023 23:33
@BastiaanOlij
Copy link
Member

Maybe rename default_env.tres to demo_env.tres and see if we can use get_configuration_warning to alert a user they haven't selected an environment.

@Malcolmnixon
Remove environment from scene_base.tscn and set environment in demo s…
4c25f17 
…cenes.

Updated physics settings.

Added check of environment property to scene_base.gd Renamed default_env.tres to demo_env.tres

Fix spacing
@BastiaanOlij BastiaanOlij merged commit 4f6e10f into GodotVR:master Apr 22, 2023
2 checks passed
@BastiaanOlij BastiaanOlij added this to the 4.1.0 milestone Apr 22, 2023
@Malcolmnixon Malcolmnixon deleted the default-environment branch April 24, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Malcolmnixon @BastiaanOlij