-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
233 - add dead zone to user settings #468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Note that depending on whether we merge this first, or #475, we could get a nasty merge conflict as I added margin containers to the UI. It may work though..
TYPE_FLOAT, | ||
PROPERTY_HINT_RANGE, | ||
"0.0,0.5,0.01", | ||
0.2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it correct our default here is 0.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when testing, I found useful adding a bit more deadzone in the x axis to avoid accidental rotation when moving forward...
the original issue suggested a value of 0.2. I'm not sure which value would be more convenient by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Owh, yeah that makes sense :)
Unfortunately I just found this PR has a bug in movement_direct.gd In the original code:
In the new code:
I'll file a bug shortly. |
I added x and y deadzone values and applied in movement direct
also added this attributes to user preferences, and added to the main level UI
I believe it can be improved as now it is checking always to react to the virtual selector
I will add some comments in the code to ask a few questions