Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

233 - add dead zone to user settings #468

Merged
merged 7 commits into from
Jul 22, 2023

Conversation

surreal6
Copy link
Contributor

I added x and y deadzone values and applied in movement direct

also added this attributes to user preferences, and added to the main level UI

I believe it can be improved as now it is checking always to react to the virtual selector

I will add some comments in the code to ask a few questions

Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Note that depending on whether we merge this first, or #475, we could get a nasty merge conflict as I added margin containers to the UI. It may work though..

TYPE_FLOAT,
PROPERTY_HINT_RANGE,
"0.0,0.5,0.01",
0.2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it correct our default here is 0.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when testing, I found useful adding a bit more deadzone in the x axis to avoid accidental rotation when moving forward...

the original issue suggested a value of 0.2. I'm not sure which value would be more convenient by default

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owh, yeah that makes sense :)

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Jul 2, 2023
@BastiaanOlij BastiaanOlij added this to the 4.2.0 milestone Jul 2, 2023
@BastiaanOlij BastiaanOlij merged commit 3b81089 into GodotVR:master Jul 22, 2023
2 checks passed
@Malcolmnixon
Copy link
Collaborator

Unfortunately I just found this PR has a bug in movement_direct.gd

In the original code:

  • Y (forwards backwards) was always applied
  • X (strafing) was only performed if strafing was enabled.

In the new code:

  • X (strafing) is always applied
  • Y (forwards backwards) is only performed if strafing is enabled.

I'll file a bug shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants