Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XRToolsHand being any depth under an XRController3D #491

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

Malcolmnixon
Copy link
Collaborator

This pull request relaxes the need for an XRToolsHand to be a direct child of an XRController3D, and instead the XRToolsHand can be any depth in the tree under an XRController3D.

This allows for more complicated hand controller configurations such as collision hands.

This allows more complicated hand trees, and is necessary for collision-hand implementations.
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this out, lgtm, can be merged :)

@Malcolmnixon Malcolmnixon merged commit bb12099 into GodotVR:master Jul 31, 2023
2 checks passed
@Malcolmnixon Malcolmnixon deleted the hand-ancestry branch July 31, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants