Improve control over pickable object highlighting #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
approved these changes
Aug 18, 2023
Malcolmnixon
force-pushed
the
highlight-request
branch
from
1a40a4a
to
a26b0fa
Compare
Replace increase/decrease_is_closest methods with highlight_request method. Modified XRToolsFunctionPickup to use highlight_request to request highlighting. Modified XRToolsSnapZone to forward highlight_request to picked up object.
Malcolmnixon
force-pushed
the
highlight-request
branch
from
a26b0fa
to
34cbf8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request switches the pickable object highlighting methods from:
to:
The old method used reference counting which was prone to dropping counts, and was intended only for proximity-triggering.
The new method saves tracks which nodes are asking for the highlight, so a node can safely set or clear its request any number of times without interfering with other requests. Additionally the highlighting could be for any reason not just proximity.
Finally this method now allows snap-zones to forward highlighting requests to objects in the snap zones. This makes it easier to see which object is ready to be pulled out of a snap-zone.