Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to a recenter request by the headset #615

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BastiaanOlij
Copy link
Member

Still working on this but adding the logic into our start_xr script so we also react on a recenter request.

At this point in time this results in the player being positioned on the XROrigin point. That may be the right solution in some scenarios but not all. So will need to play a bit more with this.

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Jan 18, 2024
@BastiaanOlij BastiaanOlij self-assigned this Jan 18, 2024
@DigitalN8m4r3
Copy link
Contributor

DigitalN8m4r3 commented Jan 18, 2024

nice this rounds things up, indeed recenter on xrorigin might fit for the current Version, since malcolm is working on the character centric solution, i dont see why the above shouldnt be merged prior. It would in essence complement the current version before the big breaking changes jump.

@BastiaanOlij
Copy link
Member Author

nice this rounds things up, indeed recenter on xrorigin might fit for the current Version, since malcolm is working on the character centric solution, i dont see why the above shouldnt be merged prior. It would in essence complement the current version before the big breaking changes jump.

The thing that is still missing is that this jumps the player back to the origin point, both when this is desired, and when it is not.
So needs a little bit more experimentation to get this right.

@DigitalN8m4r3
Copy link
Contributor

nice this rounds things up, indeed recenter on xrorigin might fit for the current Version, since malcolm is working on the character centric solution, i dont see why the above shouldnt be merged prior. It would in essence complement the current version before the big breaking changes jump.

The thing that is still missing is that this jumps the player back to the origin point, both when this is desired, and when it is not. So needs a little bit more experimentation to get this right.

indeed, right.. i got a somewhat special case to test the above.
a hide system which sets the current origin to a new one. I wonder how well this will work when using the recenter and changing from seated to standing and back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants