Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to Godot 4.2 #645

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

BastiaanOlij
Copy link
Member

This PR bumps the minimum version of Godot up to 4.2.

This includes updating of mesh data to the 4.2 format.

I've also cleaned up the teleporter scene a bit so it uses the GLB directly and saves the convex collision shapes as .shape files.
Similar changes should be made elsewhere as ArrayMesh and Convex shape data is stored very inefficiently in .tscn files.

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Jun 19, 2024
@BastiaanOlij BastiaanOlij added this to the 4.4.0 milestone Jun 19, 2024
@BastiaanOlij BastiaanOlij self-assigned this Jun 19, 2024
@BastiaanOlij BastiaanOlij force-pushed the min_version_godot_42 branch 3 times, most recently from 0fa7e16 to f027f45 Compare June 21, 2024 05:04
README.md Outdated Show resolved Hide resolved
@Malcolmnixon
Copy link
Collaborator

I'm not sure how far we want to go with the teleporter cleanup in this PR; but I found that if I correctly defined material entries in the blend/glb files, then I could attach Godot materials in the GLB importer, and have it construct the colliders (simple convex) to produce all visual and physics artifacts via import rather than post-processing in the scene.

The following is the updated blend/glb file with the material slots named so the GLB importer can correctly assign to them. teleport_glb_blend.zip

@BastiaanOlij
Copy link
Member Author

I'm not sure how far we want to go with the teleporter cleanup in this PR; but I found that if I correctly defined material entries in the blend/glb files, then I could attach Godot materials in the GLB importer, and have it construct the colliders (simple convex) to produce all visual and physics artifacts via import rather than post-processing in the scene.

The following is the updated blend/glb file with the material slots named so the GLB importer can correctly assign to them. teleport_glb_blend.zip

Yeah I went more down a rabbit hole there than I was expecting. I think its best to just merge and then do a follow up PR to improve?

@BastiaanOlij
Copy link
Member Author

I've also changed the default renderer to Compatibility and configured foveated rendering.

Copy link
Collaborator

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@Malcolmnixon Malcolmnixon merged commit 5097d07 into GodotVR:master Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants