Skip to content

Commit

Permalink
Revert "Remove unused fingerprint field from UserMetricSettings"
Browse files Browse the repository at this point in the history
This reverts commit 92d1244.
  • Loading branch information
amtriathlon committed Mar 7, 2021
1 parent 92d1244 commit e1b8293
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/Gui/EditUserMetricDialog.cpp
Expand Up @@ -317,6 +317,7 @@ EditUserMetricDialog::setSettings(UserMetricSettings &here)
here.istime = istime->isChecked();
here.precision = precision->value();
here.program = formulaEdit->document()->toPlainText();
here.fingerprint = here.symbol + DataFilter::fingerprint(here.program);
}

void
Expand Down
3 changes: 3 additions & 0 deletions src/Metrics/UserMetric.cpp
Expand Up @@ -324,6 +324,7 @@ UserMetric::addCompatibility(QList<UserMetricSettings>&metrics)
c1.precision = 0;
c1.istime = false;
c1.aggzero = true;
c1.fingerprint = c1.symbol + DataFilter::fingerprint(c1.program);
metrics.insert(0, c1);
f.compatibilitymetrics << "TSS";
}
Expand All @@ -344,6 +345,7 @@ UserMetric::addCompatibility(QList<UserMetricSettings>&metrics)
c2.precision = 3;
c2.istime = false;
c2.aggzero = true;
c2.fingerprint = c2.symbol + DataFilter::fingerprint(c2.program);
metrics.insert(0, c2);
f.compatibilitymetrics << "IF";
}
Expand All @@ -364,6 +366,7 @@ UserMetric::addCompatibility(QList<UserMetricSettings>&metrics)
c3.precision = 0;
c3.istime = false;
c3.aggzero = true;
c3.fingerprint = c3.symbol + DataFilter::fingerprint(c3.program);
metrics.insert(0, c3);
f.compatibilitymetrics << "NP";
}
Expand Down
2 changes: 2 additions & 0 deletions src/Metrics/UserMetricParser.cpp
Expand Up @@ -72,6 +72,7 @@ bool UserMetricParser::startElement( const QString&, const QString&, const QStri
if (attrs.qName(i) == "unitsImperial") add.unitsImperial=Utils::unprotect(attrs.value(i));
if (attrs.qName(i) == "conversion") add.conversion=Utils::unprotect(attrs.value(i)).toDouble();
if (attrs.qName(i) == "conversionSum") add.conversionSum=Utils::unprotect(attrs.value(i)).toDouble();
if (attrs.qName(i) == "fingerprint") add.fingerprint=Utils::unprotect(attrs.value(i));
}

return true;
Expand Down Expand Up @@ -142,6 +143,7 @@ UserMetricParser::serializeToQTextStream(QTextStream& out, QList<UserMetricSetti
out <<"type=\"" << metric.type << "\" ";
out <<"conversion=\"" << metric.conversion << "\" ";
out <<"conversionSum=\"" << metric.conversionSum << "\" ";
out <<"fingerprint=\"" << Utils::xmlprotect(metric.fingerprint) << "\" ";

out << ">\n";
out << Utils::xmlprotect(metric.program);
Expand Down
3 changes: 2 additions & 1 deletion src/Metrics/UserMetricSettings.h
Expand Up @@ -78,7 +78,8 @@ class UserMetricSettings {
double conversion,
conversionSum;

QString program;
QString program,
fingerprint; // condensed form of program
};

class EditUserMetricDialog : public QDialog {
Expand Down

0 comments on commit e1b8293

Please sign in to comment.