Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best 1000m and Best 1500m swim #3567

Closed
sabata4 opened this issue Aug 12, 2020 · 6 comments
Closed

Best 1000m and Best 1500m swim #3567

sabata4 opened this issue Aug 12, 2020 · 6 comments
Assignees
Milestone

Comments

@sabata4
Copy link

sabata4 commented Aug 12, 2020

I'm not sure if it's a issue o a problem with the activities distances with the swimming pool activities.

If i filter the swim activities in the summary tab I've configurated to see the BEST 1000 and BET 1500, and I see this:

Screenshot_1

the thing is that i have best times in 1000 and 1500 meters swim that don't are in the BEST list:

Screenshot_2

@amtriathlon
Copy link
Member

Best1000m and Best1500m are computed based on speed data and they may differ from time and distance If there are problems with the data. You can add those metrics to summary for testing or to use find intervals best pace for distance, which uses the same algorithm, to cross check.

@sabata4
Copy link
Author

sabata4 commented Aug 13, 2020

I tried what you explain.....

Screenshot_1

I'm not sure if the problem is with the data from the fit file... Maybe it's because the distance it's 0.999.... not sure... here there are some fit files that I see in the edit tab but not sure if there are any problem with them...

the truth is that in the Best 1500 there are only 5 results... but in the list there are 10 swims 1500 meters or more....

12 august swim is a 1500 meters swim.... it appears in the BEST 1000 and not in the BEST 1500 (where there are only 5 results).

Downloads.zip

@amtriathlon
Copy link
Member

The problem is the way the data is imported, it makes the distance slightly short, enough for the Best 1500 (or 1000) cannot be computed. I will look to fix it.

@amtriathlon amtriathlon self-assigned this Aug 13, 2020
@amtriathlon amtriathlon added this to the 3.6 milestone Aug 13, 2020
@sabata4
Copy link
Author

sabata4 commented Aug 13, 2020

Thanks a lot!!!

@sabata4
Copy link
Author

sabata4 commented Aug 26, 2020

I had been testing this issue in the last sanpshot (25/08) and i think that is not solved. Let me show you:

The 31 july swim is a 1000 meters swim and the time have to be on the BEST 1000 but

Screenshot_1

Screenshot_2

Here the raw data:

Screenshot_3

in the BEST 1500, you can see 6 results (only the 6 swims with more than 1500 meters, noone of the 1500 meteres swims is on the board.

@amtriathlon
Copy link
Member

amtriathlon commented Aug 26, 2020

Distance and speed data is generated at import time, so to fix previously imported activities you need to run Edit > Fix Lap Swim, or re-import them. Newly imported activities should be Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants