Set Pace Zone Shading and Pace units according to sport in CV chart #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In activities it depends on selected activity, bests are automatically filtered. In range mode it can be set by sidebar or home filters for single sport
|
We may be overusing the isRun/isSwim concept in place of a straight 'Sport' code? Thanks for continuing to develop the multisport stuff, its really really appreciated 👍 |
liversedge
added a commit
that referenced
this pull request
Jun 13, 2015
Set Pace Zone Shading and Pace units according to sport in CV chart
|
Agree, I would prefer Sport code if starting again, but we are in the middle of the river, or even near the other bank! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In activities it depends on selected activity, bests are automatically filtered.
In range mode it can be set by sidebar or home filters for single sport
a) Examples in Trends:
a1) Swims:
a2) No sport filter (mixed activities or only rides):
a3) Runs:
b) Examples in Activities:
b1) Swim selected:
b2) Ride selected:
b3) Run selected: