Add VO2 and Ventilation graphs to WorkoutWidget and add settings #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When running tests with VO2 measurements, it can be useful to see a graph of at least VO2 but also Ventilation to determine when e.g. a ramp test results in a plateau and can be considered done. * Make the color of some VO2 measurements configurable. * Add chart settings to WorkoutWindow, so that plots can be enabled or disabled. Also add the possiblity to do averaging. * Use the term Ventilation instead of Respiratory Minute Volume
|
This is how the settings dialog looks with this PR.
|
|
I'm cool with all the changes except Ridefile.h .. is that necessary? |
Move from using SeriesType from RideFile in order to allow more series to be added without modifying RideFile.
No it wasn't really :). I changed to using a custom enum for this in WorkoutWidget instead, which leaves RideFile.h as it was. I kept it as a separate commit to make it easier for you to see the update, but can squash it into the first one before it's merge-time. |
|
Thanks, that really helps. The Ridefile.h enum is used all over the codebase and likely those changes introduced a regression somewhere. |
human705
pushed a commit
to human705/GoldenCheetah
that referenced
this pull request
May 13, 2020
…denCheetah#3415) * Add VO2 and Ventilation graphs to WorkoutWidget and add settings * When running tests with VO2 measurements, it can be useful to see a graph of at least VO2 but also Ventilation to determine when e.g. a ramp test results in a plateau and can be considered done. * Make the color of some VO2 measurements configurable. * Add chart settings to WorkoutWindow, so that plots can be enabled or disabled. Also add the possiblity to do averaging. * Use the term Ventilation instead of Respiratory Minute Volume * Rework to not affect RideFile Move from using SeriesType from RideFile in order to allow more series to be added without modifying RideFile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests with VO2 measurements, it can be useful to see a
graph of at least VO2 but also Ventilation to determine when e.g. a
ramp test results in a plateau and can be considered done.
Make the color of some VO2 measurements configurable.
Add chart settings to WorkoutWindow, so that plots can be enabled or
disabled. Also add the possiblity to do averaging.
Use the term Ventilation instead of Respiratory Minute Volume