Elevation Widget: Lazy Init Polygon to Avoid 2x Route Point Iteration #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #3478 |
This gives a more Unix-like behavior when GC is launched from cmd or PowerShell, including --debug output, on release builds. Fixed GoldenCheetah#3481 [skip travis] [publish binaries]
.. still have a problem with chartspaces that have zero items that we will need to address, but this at least means when we add an overview it isn't blank. Fixes GoldenCheetah#3476
…toffersen/GoldenCheetah into ElevationWidgetSpeedup
Potentially uninitialized y gradientValue reorder member initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging the vlc hangs I found significant time being spend in the elevation widget PaintEvent, it is doing two complete passes over the ergfile points in order to compute something that only changes on widget resize. Moved elevation polygon onto the elevation widget and only recompute when needed. This reduces load and eliminates elevation widget flickering on long route files.
Unfortunately this does nothing for the hangs.