Python - Add compare support to activity series #4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All activity functions working with data series, both standard and xdata, now include an optional compare=-1 parameter. When compare mode is enabled compare parameter is used as an index to get data for the corresponding compare item, be an activity or an interval. Fixes GoldenCheetah#4346
amtriathlon
force-pushed
the
PythonCompare
branch
from
dc2dedd
to
7930b3c
Compare
To avoid confusion with compare (boolean) in other entry points.
amtriathlon
force-pushed
the
PythonCompare
branch
from
7930b3c
to
5f5bb59
Compare
|
Parameter compare (int) was changed to compareindex (int) to avoid confusion with compare (boolean) used in other API entry points. |
Contributed by Marcen at the users forum
amtriathlon
added a commit
that referenced
this pull request
Apr 15, 2023
Cumulative changes from v3.6-RC4 dbd3346 Update FIT SDK to 21.105 708d874 Support larger font scaling c85dab8 Skip previously imported files on Auto-Import (#4347) 1ecc6f9 Python - Add compare support to activity series (#4349) f0c9f12 FitRideFile - Identify Pulse Ox field ab337f1 WorkoutWizard - Remove references to FTP and CP60 00d09af Highlight current selection in Train and Trends (#4320) e7b9275 Update Italian translation fdb35bf Athlete tab colour fix (#4257) e32eabc Update German translation [publish binaries]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All activity functions working with data series,
both standard and xdata, now include an optional
compare=-1 parameter.
When compare mode is enabled compare parameter
is used as an index to get data for the corresponding compare item, be an activity or an interval.
Fixes #4346