Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guistate dependency on GUI slots & buttons causing a build error #331

Merged
merged 2 commits into from Dec 7, 2022

Conversation

NerdyPuzzle
Copy link
Contributor

@NerdyPuzzle NerdyPuzzle commented Dec 6, 2022

Closes #328

<#-- @formatter:on -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't always change them. It shouldn't be chabged in theory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What shouldn't always be changed? This is how it is done in the official generators.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you mean the formatter line then I'm pretty sure that only appears as being changed due to the difference in the amount of lines, all I did was add one line to the template.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is strange because it shouldn't appear all the time (as otherwise all others lines would also be changed).

Copy link
Owner

@Goldorion Goldorion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Goldorion Goldorion merged commit 1ce9041 into Goldorion:1.19.2 Dec 7, 2022
@NerdyPuzzle NerdyPuzzle deleted the patch-7 branch December 8, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Get text inside textfield ()" build fail
2 participants