Merge with latest auto-complete-clang, and cleanup. #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your e-mail address shown on GitHub doesn't seem to work, so I'm sending this from here:
Hi, you might've noted that I forked your project.
I merged it (manually) with hara's latest version of
auto-complete-clang (which is the latest code from brianjcj plus
Objective-C support), and also did a lot of clean-up to meet
elisp-coding standards. I might have broken things while doing all
this, and can't reliably test it myself because I don't know how
exactly your original code is supposed to behave (I probably have a
different clang version and all). So it would be very friendly if you
could test my version and see if it behaves well. If it does, I would
ask you to merge it and continue working from there.
In case you wonder what "elisp-coding standards" I'm talking about,
the biggest issue with your code was that it defines functions and
variables with generic names like
completion-proc
,filter-output
,parse-completion-results
,send-source-code
, etc., which all end upin the global function/variable namespaces of the emacs user. Imagine
how many different elisp packages/libraries might be using a generic
function like "filter-output"... So to avoid clashes, everyone should
adhere to the convention that all functions and variables in a
package/library are prefixed with a unique identifier of the
package. E.g. in this case we use
ac-clang-async-filter-output
.Regards, and thanks for the code
Taylan