Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing a player will now remove the corresponding pfp on the database. #270

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

FrankreedX
Copy link
Contributor

@FrankreedX FrankreedX commented Jun 23, 2024

Also refactored files and functions in hooks to dbOperations, with hooks as a subfolder.
Also replaced more references to "1" with teamId or similar
closes #243

Copy link
Contributor

@Gehrkej Gehrkej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, I like what you did with the image upload hook in having it take in height and width so it can be used in other situations as well.

@FrankreedX FrankreedX merged commit 9b07911 into main Jul 11, 2024
1 check passed
@FrankreedX FrankreedX deleted the frankreed/delete-pfp-with-players branch July 11, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a user is deleted, their pfp in storage is not deleted with them.
2 participants