fix: avoid using namespace #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
style: pre-commit fixes fix: avoid using namespace
henryiii
force-pushed
the
henryiii/chore/cleanup
branch
from
7bab32f
to
e0d2144
Compare
henryiii
added a commit
that referenced
this pull request
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the abominable practice of
using namespace std. Besides adding confusion, hindering readability, and being an antipattern, this was breaking GooFit's ability to compile in C++17 mode, since makingstd::dataintodataconflicts with variables nameddata, causing ambiguous expressions.We still have a problem with fmt using things deprecated in C++17 that would be solved by updating fmt, but that needs a newer CUDA, which will be in a future PR.