Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoodWallet Ethereum support - enhancements #4083

Closed
3 tasks done
johnsmith-gooddollar opened this issue Sep 6, 2023 · 4 comments
Closed
3 tasks done

GoodWallet Ethereum support - enhancements #4083

johnsmith-gooddollar opened this issue Sep 6, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@johnsmith-gooddollar
Copy link
Collaborator

johnsmith-gooddollar commented Sep 6, 2023

  • replace hardcoded titles like const RECEIVE_TITLE = 'Receive G$' with the new NavBar substituting token name everywhere
  • if a single transaction does both native transfer and token transfer then they will override each other - need a solution for this
  • find solution for unsafe wallet passing to threaddb
@johnsmith-gooddollar johnsmith-gooddollar added the enhancement New feature or request label Sep 6, 2023
@johnsmith-gooddollar
Copy link
Collaborator Author

johnsmith-gooddollar commented Sep 6, 2023

  1. those constants are used in some different screens, also some screens have own nav options
    it cannot just be fixed at utils/sendReceiveFlow.js and will take some time to refactor

@johnsmith-gooddollar
Copy link
Collaborator Author

if a single transaction does both native transfer and token transfer then they will override each other - need a solution for this

regarding this one - I had a talk with @sunela-tr
we found in this case APIs will return both transactions under the same hash but with different props (e.g. transactionType, transactionSubtype). In getNativeTxs method of API.js I'm filtering out everything except transactionTypes = 'native' AND transactionSubtype <> 'zero-transfer'. So the native transaction coming with erc20 token transfer won't be processed and show in the feed and won't interfere with anything.

@patpedrosa
Copy link
Collaborator

@johnsmith-gooddollar Can this be closed?

@johnsmith-gooddollar
Copy link
Collaborator Author

@patpedrosa yes, the following PR was merged: #4091

@vldkhh vldkhh closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants