Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletChat Integration UI Fixes #4135

Merged
merged 110 commits into from Nov 17, 2023
Merged

WalletChat Integration UI Fixes #4135

merged 110 commits into from Nov 17, 2023

Conversation

izuchukwu-eric
Copy link
Contributor

Description

This PR contains requested changes and bug fixes as regarding the integration of WalletChat.

  • Improved loading state of the WalletChat iframe when clicked
  • Addressed styling issues for both web and android
  • X button to close out the WalletChat iframe

About # (link your issue here)

How Has This Been Tested?

Changes has been tested by the GD team

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

@L03TJ3

izuchukwu-eric and others added 30 commits August 1, 2023 10:18
… but is not displaying it correctly yet"

This reverts commit ac08fb7.
Co-authored-by: LewisB <lewis@gooddollar.org>
Copy link

vercel bot commented Nov 16, 2023

@izuchukwu-eric is attempting to deploy a commit to the GoodDollarTeam Team on Vercel.

A member of the Team first needs to authorize it.

@L03TJ3 L03TJ3 merged commit d9e21b3 into GoodDollar:master Nov 17, 2023
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants