Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Bug) #679 Dashboard: Send and Receive icons should be bigger and not at th… #688

Merged
merged 1 commit into from Oct 7, 2019
Merged

(Bug) #679 Dashboard: Send and Receive icons should be bigger and not at th… #688

merged 1 commit into from Oct 7, 2019

Conversation

StanislavShevchenko
Copy link
Contributor

@StanislavShevchenko StanislavShevchenko commented Oct 3, 2019 •
edited by AlexeyKosinski

Description

Button icons send and receive set size taken from design
Fixes #679

How Has This Been Tested?

Register and go to the dashboard

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request ( for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

image

@StanislavShevchenko StanislavShevchenko changed the title #679 Dashboard: Send and Receive icons should be bigger and not at th… (Bug) #679 Dashboard: Send and Receive icons should be bigger and not at th… Oct 3, 2019
@sirpy sirpy requested a review from LiavGut October 3, 2019 18:10
LiavGut
LiavGut reviewed Oct 3, 2019
View reviewed changes
Copy link

@LiavGut LiavGut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cool

@sirpy sirpy merged commit fc2e923 into master Oct 7, 2019
@sirpy sirpy deleted the #679-Send-and-Receive-icons-should-be-bigger branch December 24, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiavGut LiavGut LiavGut left review comments

@sirpy sirpy sirpy approved these changes

@AlexeyKosinski AlexeyKosinski AlexeyKosinski approved these changes

@yaroslav-fedyshyn-nordwhale yaroslav-fedyshyn-nordwhale yaroslav-fedyshyn-nordwhale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard: Send and Receive icons should be bigger and not at the same hight of the text label
5 participants
@StanislavShevchenko @sirpy @AlexeyKosinski @yaroslav-fedyshyn-nordwhale @LiavGut