refactored for PRs comments

GoodDollar · Mar 20, 2020 · 30def24 · 30def24
1 parent 40c2cc6
commit 30def24
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 15 deletions.
diff --git a/src/server/server.config.js b/src/server/server.config.js
@@ -387,6 +387,18 @@ const conf = convict({
     format: '*',
     env: 'HANUKA_END_DATE',
     default: undefined
+  },
+  humanOptions: {
+    doc: 'Options for humanApi',
+    format: Object,
+    env: 'HUMAN_OPTIONS',
+    default: {
+      livenessThresh: 0.8,
+      uniqueThresh: 0.7,
+      minEnrollImages: 1,
+      maxHeadAngle: 10,
+      minPhashSimilarity: 0.95
+    }
   }
 })
 

diff --git a/src/server/verification/faceRecognition/human.js b/src/server/verification/faceRecognition/human.js
@@ -5,14 +5,4 @@ const { id: app_id, key: app_key } = conf.kairos
 
 const apiKairos = new kairosAPI({ app_id, app_key }, 'test', true)
 
-export default new humanApi(
-  apiKairos,
-  {
-    livenessThresh: 0.8,
-    uniqueThresh: 0.7,
-    minEnrollImages: 1,
-    maxHeadAngle: 10,
-    minPhashSimilarity: 0.95
-  },
-  true
-)
+export default new humanApi(apiKairos, conf.humanOptions, true)
diff --git a/src/server/verification/verification.js b/src/server/verification/verification.js
@@ -45,7 +45,7 @@ class Verifications implements VerificationAPI {
               .updateUser({ identifier: user.loggedInAs, isVerified: true })
               .then(updatedUser => this.log.debug('updatedUser:', updatedUser))
           ])
-          await sessionRef.get({ isWhitelisted: true })
+          sessionRef.get({ isWhitelisted: true })
         } catch (e) {
           this.log.error('Whitelisting failed', e)
           sessionRef.put({ isWhitelisted: false, isError: e.message })

diff --git a/src/server/verification/verificationAPI.js b/src/server/verification/verificationAPI.js
@@ -58,15 +58,14 @@ const setup = (app: Router, verifier: VerificationAPI, storage: StorageAPI) => {
         } catch (e) {
           log.error('Facerecognition error:', { e })
           sessionRef.put({ isDuplicate: true, isLive: false, isError: e.message })
-          result = { ok: 1, error: e.message, isVerified: false }
+          result = { ok: 0, error: e.message, isVerified: false }
         }
       } else {
         sessionRef.put({ isDuplicate: false, isLive: true, isEnrolled: true }) // publish to subscribers
         // mocked result for verified user or development mode
         result = {
           ok: 1,
-          isVerified: true,
-          enrollResult: { alreadyEnrolled: true, enrollmentIdentifier: true }
+          isVerified: true
         }
       }