fix: user delete, make sure we have identifier set

GoodDollar · Aug 11, 2019 · 983f508 · 983f508
1 parent 1072705
commit 983f508
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/server/login/login-middleware.js b/src/server/login/login-middleware.js
@@ -24,7 +24,7 @@ export const strategy = new Strategy(jwtOptions, async (jwtPayload, next) => {
   let user = await GunDBPrivate.getUser(jwtPayload.loggedInAs)
   log.debug('payload received', { jwtPayload, user })
   //if user is empty make sure we have something
-  user = defaults(user, jwtPayload)
+  user = defaults(user, jwtPayload, { identifier: jwtPayload.loggedInAs })
   if (get(jwtPayload, 'loggedInAs')) {
     next(null, user)
   } else {

diff --git a/src/server/storage/storageAPI.js b/src/server/storage/storageAPI.js
@@ -80,7 +80,7 @@ const setup = (app: Router, storage: StorageAPI) => {
         Helper.delete(body.zoomId)
           .then(r => ({ zoom: 'ok' }))
           .catch(e => ({ zoom: 'failed' })),
-        (user.identifier ? storage.deleteUser(user) : Promise.resolve())
+        (user.identifier ? storage.deleteUser(user) : Promise.reject())
           .then(r => ({ gundb: 'ok' }))
           .catch(e => ({ gundb: 'failed' })),
         Mautic.deleteContact(user)