Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server should verify new user email from W3 #59

Closed
sirpy opened this issue Aug 27, 2019 · 0 comments · Fixed by #62
Closed

Server should verify new user email from W3 #59

sirpy opened this issue Aug 27, 2019 · 0 comments · Fixed by #62
Assignees
@AlexeyKosinski @yaroslav-fedyshyn-nordwhale
Milestone
Alpha2 Rejects An...

Comments

@sirpy
Copy link
Contributor

sirpy commented Aug 27, 2019

When user signs up from W3, we pull details from W3 on the client.
This is a failure point since the client can to the server any information.
Server must verify the email the user sent is really from our W3 backend

Two options:

  • W3 signs user data with timestamp valid for 1 minute and client send this signature to backend with his signup details
  • OR client send w3 token with signup details and server request user details
@sirpy sirpy added this to the Alpha2 Rejects And Integrations milestone Aug 27, 2019
yaroslav-fedyshyn-nordwhale added a commit that referenced this issue Aug 28, 2019
@yaroslav-fedyshyn-nordwhale
add: verification of web3 user email on server (#59)
c3b181c
Merged
@sirpy sirpy closed this as completed in #62 Sep 3, 2019
sirpy pushed a commit that referenced this issue Sep 3, 2019
@yaroslav-fedyshyn-nordwhale @sirpy
add: verification of web3 user email on server (#59) (#62)
6538b3c 
* add: verification of web3 user email on server (#59)

* fix: "add log for fetch web3 user error", "update user's isEmailVerified field after checking" (#415)

* refactor: "log error with lo.erro method, not debug"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyKosinski AlexeyKosinski

@yaroslav-fedyshyn-nordwhale yaroslav-fedyshyn-nordwhale

Labels
None yet
Projects
None yet
Milestone
Alpha2 Rejects And Integrations
Development

Successfully merging a pull request may close this issue.

add: verification of web3 user email on server (#59) GoodDollar/GoodServer
3 participants
@sirpy @AlexeyKosinski @yaroslav-fedyshyn-nordwhale