Merge a2bcba3 into c3e051e

Goodluckhf · Aug 11, 2019 · 50d9b2e · 50d9b2e
2 parents c3e051e + a2bcba3
commit 50d9b2e
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/src/instance-wrappers/factory-instance-wrapper.ts b/src/instance-wrappers/factory-instance-wrapper.ts
@@ -14,7 +14,7 @@ export class FactoryInstanceWrapper extends InstanceWrapper {
   public constructor(
     contextModule,
     {
-      dependencies,
+      dependencies = [],
       factory,
       ...instanceWrapperArguments
     }: FactoryInstanceWrapperArguments,

diff --git a/src/integration-tests/one-module.spec.ts b/src/integration-tests/one-module.spec.ts
@@ -218,4 +218,36 @@ describe('Inverse of Control: one module', function() {
       expect(e).toBeInstanceOf(CircularDependencyError);
     }
   });
+
+  it('Should not throw error useClass without dependencies', () => {
+    const container = new IoCContainer();
+    const diManifest: ManifestInterface = {
+      moduleName: 'tesModule',
+      providers: [
+        {
+          token: 'TestServiceA',
+          useClass: TestServiceA,
+        },
+      ],
+    };
+
+    container.loadManifests([diManifest]);
+    container.compile();
+  });
+
+  it('Should not throw error useFactory without dependencies', () => {
+    const container = new IoCContainer();
+    const diManifest: ManifestInterface = {
+      moduleName: 'tesModule',
+      providers: [
+        {
+          token: 'TestServiceA',
+          useFactory: () => true,
+        },
+      ],
+    };
+
+    container.loadManifests([diManifest]);
+    container.compile();
+  });
 });