Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restrict datadog<0.31.0 #4

Merged
merged 1 commit into from
Nov 5, 2019
Merged

restrict datadog<0.31.0 #4

merged 1 commit into from
Nov 5, 2019

Conversation

shawnjoseph
Copy link
Contributor

@shawnjoseph shawnjoseph commented Nov 4, 2019 •
edited
Loading

Datadog/datadogpy 0.31.0 release introduced a changed recently that broke our statsd wrapper.

"[ERROR] TypeError: get_hostname() missing 1 required positional argument: 'hostname_from_config'..."

Restricting datadog>0.31.0 fixes this problem.

DataDog/datadogpy#428

@shawnjoseph shawnjoseph added the bug Something isn't working label Nov 4, 2019
@shawnjoseph shawnjoseph self-assigned this Nov 4, 2019
codeadict
codeadict approved these changes Nov 4, 2019
View reviewed changes
Copy link

@codeadict codeadict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good

@shawnjoseph shawnjoseph merged commit e641a86 into master Nov 5, 2019
@shawnjoseph shawnjoseph deleted the restrict_v0.31.0 branch November 5, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeadict codeadict codeadict approved these changes

@ramonPaulAlvarez ramonPaulAlvarez ramonPaulAlvarez approved these changes

Assignees

@shawnjoseph shawnjoseph

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shawnjoseph @codeadict @ramonPaulAlvarez