Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#28 handle empty response #31

Merged
merged 5 commits into from Oct 13, 2022
Merged

#28 handle empty response #31

merged 5 commits into from Oct 13, 2022

Conversation

ozair-dev
Copy link
Contributor

@ozair-dev ozair-dev commented Oct 12, 2022

I have added the text for when the response is empty. Plus I have done some code refactoring as I noticed that the logic was poorly coded. Please review the PR.
Screenshot from 2022-10-12 21-06-47

Fixed #28

@Dhruv031003
Copy link
Collaborator

@ozair-dev
Thanks for the code refactoring but there are multiple issues.

image
image

  • These loaders should be in the middle horizontally.

  • If page is reloaded before the tweets load or while new tweets are being loaded it shows the alert, if possible remove it or just console log the error.

  • If we go to the end of any page i.e. if there are no more tweets left and then you change any input value it shows "Your search did not return any results" and then after some time loads the new tweets.

Copy link
Collaborator

@Dhruv031003 Dhruv031003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are requested.

@netlify
Copy link

netlify bot commented Oct 13, 2022

Deploy Preview for remotebirdjobs ready!

Name Link
🔨 Latest commit d268058
🔍 Latest deploy log https://app.netlify.com/sites/remotebirdjobs/deploys/63483cad6db2d200081fc539
😎 Deploy Preview https://deploy-preview-31--remotebirdjobs.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ozair-dev
Copy link
Contributor Author

  • If page is reloaded before the tweets load or while new tweets are being loaded it shows the alert, if possible remove it or just console log the error
  • If we go to the end of any page i.e. if there are no more tweets left and then you change any input value it shows "Your search did not return any results" and then after some time loads the new tweets.

These loaders should be in the middle horizontally.

I already set the loader in the middle in my last commit. I rechecked it and it is working fine on my machine. You can also see my changes in the Spinner component. If you still see the issue then I want you deploye my changes to production and I'll see for myself what the issue is.
Screenshot from 2022-10-13 20-46-47

@Dhruv031003
Copy link
Collaborator

@ozair-dev

  • If page is reloaded before the tweets load or while new tweets are being loaded it shows the alert, if possible remove it or just console log the error
  • If we go to the end of any page i.e. if there are no more tweets left and then you change any input value it shows "Your search did not return any results" and then after some time loads the new tweets.

These loaders should be in the middle horizontally.

I already set the loader in the middle in my last commit. I rechecked it and it is working fine on my machine. You can also see my changes in the Spinner component. If you still see the issue then I want you deploye my changes to production and I'll see for myself what the issue is. Screenshot from 2022-10-13 20-46-47

Okay, my bad i didn't view the code properly.
All the issues are fixed I am merging it.

Thanks for the contribution, Keep contributing, Keep growing 😊

@Dhruv031003 Dhruv031003 merged commit e85024a into Google-Developer-Student-Club-RJIT:main Oct 13, 2022
@ozair-dev ozair-dev deleted the #28-handle-empty-response branch October 13, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Api Response Empty
2 participants