Feature/conference stubs 16 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Builds, runs, spits out lots of stub. LGTM. One thing we should try to address in a future PR is the outbound DateTime format. I'll create an issue to discuss that proposal. |
| @@ -4,7 +4,7 @@ | |||
| import org.springframework.boot.autoconfigure.EnableAutoConfiguration; | |||
| import org.springframework.context.annotation.ComponentScan; | |||
|
|
|||
| @ComponentScan | |||
| @ComponentScan(basePackages = {"hello", "com.ioextendedgr.web"}) | |||
There was a problem hiding this comment.
Can we move this Application.java class out of this /hello/ package?
There was a problem hiding this comment.
Nevermind. I already created an issue to do all this cleanup..
mccrackend
added a commit
that referenced
this pull request
Feb 7, 2015
…onference_stubs_16 Feature/conference stubs 16
|
@mccrackend When you merged this in and brought the branch back, was there something missing that you were looking for as to not close out the #16 ? |
|
Weird. Not sure why it didn't auto close the issue - i thought it normally did that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fulfills #16
Specifically, there is now an endpoint /conference that will retrieve a mock list of conference view objects with their associated location.
This can be tested by bringing up the application and hitting the /conference url. This only does a GET. POST, UPDATE and DELETE operations are not yet supported.