This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
fix: don't die in browsers that do not support shadow DOM. Fixes #255. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there anything else that needs to be done to get this PR integrated? Any missing information? |
|
any chance to get this merged? |
|
We may want to review the need for this change given any updates to ShadowDOM specs for V1. I'll need to take another look at the original issue. |
|
@addyosmani is there anything I can do to get this merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some browser supported don't support Shadow DOM. However the DOMUtils expect this. Fixes #255.