Move check for name-from:content out of getTextFromDescendantContent and... #53
Conversation
…and use getTextFromDescendantContent instead of getTextAlternatives in MainRoleOnInappropriateElement test
ghost
self-assigned this
| @@ -255,8 +255,17 @@ axs.properties.findTextAlternatives = function(node, textAlternatives, opt_recur | |||
|
|
|||
| // 2C. Otherwise, if the attributes checked in rules A and B didn't provide results, text is | |||
| // collected from descendant content if the current element's role allows "Name From: contents." | |||
There was a problem hiding this comment.
Nit: would it be more accurate to say: "text is collected from descendant content unless the current element's role does not allow "Name From: contents."?
(because if there's no role, text is collected from descendant content)
Is this doing the right thing for standard html elements too, or does that matter? there are other html elements where the name never comes from descendant content, like - is that handled already?
There was a problem hiding this comment.
This is verbatim from the spec: http://www.w3.org/TR/wai-aria/roles#textalternativecomputation
There was a problem hiding this comment.
I agree it should be more selective about calculating name from contents for native HTML elements, however I'd rather make that a separate issue.
Could you possibly file a bug with a pointer to the relevant documentation? I had a quick look through the ARIA spec and couldn't find it.
|
lgtm |
Move check for name-from:content out of getTextFromDescendantContent and...
... use getTextFromDescendantContent instead of getTextAlternatives in MainRoleOnInappropriateElement test
This was previously committed but got clobbered by a later commit.
Fixes bug reported here: https://groups.google.com/forum/#!category-topic/introduction-to-web-accessibility/ChGzBSe0_yU